Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question regarding renaming core to _core #78

Closed
mtsokol opened this issue Sep 17, 2023 · 3 comments
Closed

Question regarding renaming core to _core #78

mtsokol opened this issue Sep 17, 2023 · 3 comments

Comments

@mtsokol
Copy link

mtsokol commented Sep 17, 2023

Hi!
In the numpy/numpy#24634 PR, numpy.core is being renamed to numpy._core which affects .github/workflows/build-numpy.yml file here.

Would renaming core path to _core work here? Or do you need to run the CI against other numpy versions?
@r-devulap
Copy link
Contributor

@mtsokol thanks for reaching out. I think renaming core to _core would work just fine. I can update our CI once your PR is merged.

@mtsokol
Copy link
Author

mtsokol commented Oct 17, 2023

Hi @r-devulap, numpy/numpy#24634 has been merged!

@r-devulap
Copy link
Contributor

thank you. I have updated our CI with that change. See #87

@mtsokol mtsokol closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtsokol @r-devulap