Fix bug in Autocomplete. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original version, [<Name "source">] for each type of completer. This resuled in WebSharper generating four distinct target values (i.e. source, source1, source2, source3), which caused autocomplete to fail for all but the first completer (simple array). Furthermore, autocomplete() in JQueryUI.js expects a callback with two arguments, but the translated (F#) callback expects an array with two elements. This is fixed by bridging the call to the F# function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original version,
[<Name "source">]was used for each type of completer. This resulted in WebSharper generating four distinct target values (i.e.source, source1, source2, source3), which caused autocomplete to fail for all but the first completer (simple array). Furthermore,autocomplete()in JQueryUI.js expects a callback with two arguments, but the translated (F#) callback expects an array with two elements. This is fixed by bridging the call to the F# function.