New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make non-breaking RPC changes possible #598

Closed

Jand42 opened this issue Aug 26, 2016 · 1 comment

Labels

enhancement fixed in ws4 websharper4

Member

Jand42 commented Aug 26, 2016

RPC Method handles could be changed to be a path+hash of signature. Advantages:

adding/reordering any kind of new RPC methods are not breaking existing client builds
server can report exactly if a method has been removed or signature changed from an older client (client could throw a special exception on rpc incompatibility)
build and bundling could detect if a call to the same rpc with different signatures are used from refererenced libraries, this would throw an incompatibility error/warning

Jand42 changed the title ~~make non-breaking RPC changes possible~~ Make non-breaking RPC changes possible

Jand42 added enhancement websharper4 labels

Jand42 added a commit that referenced this issue


          #598: RPC method handle is asm+path+signature hash

d260127

Jand42 added the fixed in ws4 label

Member Author

Jand42 commented May 22, 2017

TODO: make RPC signature hash computing platform-independent.

Jand42 added a commit that referenced this issue


          #598 use custom hashing for rpc signature hashes

d4dcc89

Jand42 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment