From 536cdf28893ef6f740d3ad2767ec4fba5dbb732e Mon Sep 17 00:00:00 2001 From: Florian Weber Date: Wed, 22 Feb 2017 16:18:05 +0100 Subject: [PATCH 1/2] Use correct PHPdoc types for user IDs --- src/IntercomUsers.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/IntercomUsers.php b/src/IntercomUsers.php index e54220f..7166df6 100644 --- a/src/IntercomUsers.php +++ b/src/IntercomUsers.php @@ -55,7 +55,7 @@ public function getUsers($options) /** * Gets a single User based on the Intercom ID. * @see https://developers.intercom.com/reference#view-a-user - * @param integer $id + * @param string $id * @param array $options * @return mixed * @throws \GuzzleHttp\Exception\GuzzleException @@ -81,7 +81,7 @@ public function scrollUsers($options = []) /** * Deletes a single User based on the Intercom ID. * @see https://developers.intercom.com/reference#delete-a-user - * @param integer $id + * @param string $id * @param array $options * @return mixed * @throws \GuzzleHttp\Exception\GuzzleException @@ -92,6 +92,10 @@ public function deleteUser($id, $options = []) return $this->client->delete($path, $options); } + /** + * @param string $id + * @return string + */ public function userPath($id) { return 'users/' . $id; From 8d3d848b743dc548d670d1817378815c999c09a4 Mon Sep 17 00:00:00 2001 From: Florian Weber Date: Wed, 22 Feb 2017 16:24:05 +0100 Subject: [PATCH 2/2] Use correct type for $query parameter for get() method --- src/IntercomClient.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/IntercomClient.php b/src/IntercomClient.php index a02e6ae..989b5c0 100644 --- a/src/IntercomClient.php +++ b/src/IntercomClient.php @@ -151,7 +151,7 @@ public function delete($endpoint, $json) /** * @param string $endpoint - * @param string $query + * @param array $query * @return mixed * @throws \GuzzleHttp\Exception\GuzzleException */