Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConversationTest failing on type parameter #41

Closed
dehora opened this issue Sep 16, 2014 · 0 comments
Closed

ConversationTest failing on type parameter #41

dehora opened this issue Sep 16, 2014 · 0 comments
Labels

Comments

@dehora
Copy link
Contributor

dehora commented Sep 16, 2014

ConversationTest.php is expecting a type=user parameter to be set automatically but there's none. Looking at the guzzle definition file for conversation, it doesn't have a default value.

"type": {
                    "location": "query",
                    "required": true,
                    "static": true,
                    "default": "user"
                },

phpunit run below


There was 1 failure:

1) Intercom\ConversationTest::testGetConversations
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'/conversations?type=user'
+'/conversations'

/Users/dehora/intercom/intercom-php/src/Intercom/IntercomTestCase.php:51
/Users/dehora/intercom/intercom-php/tests/Intercom/Resources/ConversationTest.php:50

FAILURES!
Tests: 77, Assertions: 236, Failures: 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant