Updates on public peers list #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasted ipv6 peers on new file
Create public_peers_6.txt
- Removed all IPv6 (see public_peers_6.txt) - Remained alive from list are only two :(
… a new variable in comments but no implementation yet for ipv6 peers.
…lder. First time touched vbs.
|
I am not sure what to do with that. Is a very specific thing that blindly removes the 117th line, but this could behave really wrong if configuration already exists and it's not run on a fresh install. |
|
Excellent stuff @kaotisk-hund, thank you! I agree we with you, removing a line blindly is risky. Could you please add a simple check for the contents of that 117th line, and only remove it, if it is matches the current "]," value? Also, I couldn't tell where/if we are calling the fixBrokenConfig.vbs file. Could you make sure that it's included as an installation step? I will compile it on Windows, test it in a week and get back to you. |
andrasfuchs
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24
This is the final files.
Only 2 peers for ipv4
ipv6 peers on their own file
also ipv6 peers are not pinged/tested at this point