Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Internal Server Error when redirecting to interaction #2826

Closed
raducristianpopa opened this issue Jul 26, 2024 · 1 comment · Fixed by #2832
Closed

[BUG] Internal Server Error when redirecting to interaction #2826

raducristianpopa opened this issue Jul 26, 2024 · 1 comment · Fixed by #2832
Assignees
Labels
type: bug Something isn't working

Comments

@raducristianpopa
Copy link
Member

raducristianpopa commented Jul 26, 2024

Bug Report

Describe the bug

After an interactive grant is created and an application tries to redirect the user to the URL, there is an Internal Server Error.
This is not happening on a regular basis. After the page is refreshed, the user is correctly redirected to the IdP page.

To Reproduce

This happened to me when connecting my wallet from Rafiki Money to the Web Monetization Extension

Expected behavior

The user should be redirected directly to the IdP page, without having to refresh a page that showcases an Internal Server Error.

Desktop (please complete the following information):

  • OS: [e.g. Ubuntu]
  • Version [e.g. 20.04LTS]
  • Node version [e.g. 18.16.0]
  • pnpm version [e.g. 8.6.7]
  • Browser [e.g. chrome, safari]

Screenshots
image

Additional context

  • Logs from Rafiki Auth (rafiki.money)
  TypeError: option maxAge is invalid
      at new Cookie (/home/rafiki/node_modules/.pnpm/cookies@0.9.1/node_modules/cookies/index.js:182:11)
      at Cookies.set (/home/rafiki/node_modules/.pnpm/cookies@0.9.1/node_modules/cookies/index.js:117:16)
      at ContextSession.save (/home/rafiki/node_modules/.pnpm/koa-session@6.4.0/node_modules/koa-session/lib/context.js:331:26)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async ContextSession.commit (/home/rafiki/node_modules/.pnpm/koa-session@6.4.0/node_modules/koa-session/lib/context.js:244:5)
      at async session (/home/rafiki/node_modules/.pnpm/koa-session@6.4.0/node_modules/koa-session/index.js:46:9)
      at async cors (/home/rafiki/node_modules/.pnpm/@koa+cors@5.0.0/node_modules/@koa/cors/index.js:109:16)

When your rafiki.money tab opens, it sometimes fails to provide a functioning URL and requires refreshing!

@raducristianpopa raducristianpopa added the type: bug Something isn't working label Jul 26, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Jul 26, 2024
@sabineschaller sabineschaller moved this from Backlog to In Progress in Rafiki Aug 1, 2024
@sabineschaller sabineschaller self-assigned this Aug 1, 2024
@sabineschaller
Copy link
Member

I was able to reproduce this on the localenv by requesting multiple outgoing payment grants (which require interaction) through Bruno. On the 4th try, I saw the Internal Server Error when opening the redirect link from Bruno.

@BlairCurrey BlairCurrey self-assigned this Aug 2, 2024
@BlairCurrey BlairCurrey moved this from In Progress to Ready for Review in Rafiki Aug 6, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Rafiki Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants