Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mulit-Tenant] auth Tenant Admin Graphql API #3125

Open
3 of 4 tasks
Tracked by #2893
njlie opened this issue Nov 21, 2024 · 4 comments
Open
3 of 4 tasks
Tracked by #2893

[Mulit-Tenant] auth Tenant Admin Graphql API #3125

njlie opened this issue Nov 21, 2024 · 4 comments
Assignees
Labels
pkg: auth Changes in the GNAP auth package.

Comments

@njlie
Copy link
Contributor

njlie commented Nov 21, 2024

Add the following to auth Admin GraphQL API:

type Mutation {
  createTenant(input: CreateTenantInput): CreateTenantMutationResponse!
  updateTenant(input: UpdateTenantInput): UpdateTenantMutationResponse!
  deleteTenant(input: DeleteTenantInput): DeleteTenantMutationResponse!
}
  • createTenant mutation
  • updateTenant mutation
  • deleteTenant mutation
  • document any new env vars and ensure helm charts are updated

Prerequisites

@njlie njlie added the pkg: auth Changes in the GNAP auth package. label Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Nov 21, 2024
@njlie njlie mentioned this issue Nov 21, 2024
38 tasks
@mkurapov
Copy link
Contributor

mkurapov commented Nov 26, 2024

What do we think about having this as an event we publish from backend to be consumed by auth and stored in the tenant TB?

Otherwise, we should find a way to hide this from the documentation

@njlie
Copy link
Contributor Author

njlie commented Dec 2, 2024

What do we think about having this as an event we publish from backend to be consumed by auth and stored in the tenant TB?

What kind of event did you have in mind? Pretty much any communication between these services will suffice.

@mkurapov
Copy link
Contributor

mkurapov commented Dec 2, 2024

I was thinking something like redis pub sub/streams as a message queue, but for V1 we can get away without using new patterns/technologies and just use a separate GraphQL API

@BlairCurrey BlairCurrey self-assigned this Dec 3, 2024
@BlairCurrey BlairCurrey moved this from Backlog to In Progress in Rafiki Dec 3, 2024
@BlairCurrey
Copy link
Contributor

Per our discussion on slack we decided to host this api on a new http server because:

  1. we dont want to expose it on the graphql admin api
  2. a new graphql api for this is a bit heavy-handed
  3. a new http server would be a bit simpler than something like GRPC. No extra dependencies, codegen, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: auth Changes in the GNAP auth package.
Projects
Status: In Progress
Development

No branches or pull requests

3 participants