Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): soft delete access tokens and grant accesses #2837

Merged
merged 1 commit into from
Aug 8, 2024
Merged

feat(auth): soft delete access tokens and grant accesses #2837

merged 1 commit into from
Aug 8, 2024

Conversation

njlie
Copy link
Contributor

@njlie njlie commented Aug 2, 2024

Changes proposed in this pull request

  • Soft delete access items on grant revocation
  • Soft delete access tokens on revocation & grant revocation

Context

Fixes #2819

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Bruno collection updated

@njlie njlie requested review from BlairCurrey and mkurapov August 2, 2024 22:11
@github-actions github-actions bot added type: tests Testing related type: source Changes business logic pkg: auth Changes in the GNAP auth package. labels Aug 2, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 2, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 0d308c6
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66ad59a344b3d5000863933d

mkurapov
mkurapov approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@njlie njlie merged commit 4a43281 into main Aug 8, 2024
36 of 42 checks passed
@njlie njlie deleted the nl/2819/soft-delete-access branch August 8, 2024 14:22
sabineschaller pushed a commit that referenced this pull request Aug 15, 2024
@njlie @sabineschaller
feat(auth): soft delete access tokens and grant accesses (#2837)
8f3c147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@BlairCurrey BlairCurrey Awaiting requested review from BlairCurrey

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not hard delete access and access tokens in auth service
2 participants
@njlie @mkurapov