Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/channel/edit save button is always active #141

Open
4www opened this issue Nov 19, 2017 · 2 comments
Open

/channel/edit save button is always active #141

4www opened this issue Nov 19, 2017 · 2 comments
Labels
enhancement help wanted

Comments

@4www
Copy link
Contributor

4www commented Nov 19, 2017

the button save on /channel/edit should be disabled when:

  • save task is running (it is)
  • no changes have been made to the model (it is not)
@oskarrough
Copy link
Member

I tried to do it for the model hasDirtyAttributes. But couldn't make it work because of the way we use a proxy object to hold the changes to the channel before applying them.

@oskarrough
Copy link
Member

Now there's a 'No changes to save' notification, so it doesn't feel like a bug anymore to me. Would still be nicer if the button was disabled but yea…

@4www 4www mentioned this issue Sep 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oskarrough @4www