Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create instruction of how to create dev/draft copy of our Dialog Flow App and add helpful scripts #148

Open
7 tasks
hyzhak opened this issue Mar 15, 2018 · 6 comments
Assignees
Labels
enhancement New feature or request project accessibility project accessibility

Comments

@hyzhak
Copy link
Member

hyzhak commented Mar 15, 2018

  • please make a search in github for similar projects, I see at least one of them
  • we need: script which makes a dump of our Dialog Flow App (so each time we could copy (*)
  • script which deploy dump to Dialog Flow
  • we should extend Script for uploading dialog flow #33 so we don't need to dump collection which we fetch from IA
  • short instruction in README step-by-step how to create dev/draft copy of Dialog Flow
  • and don't forget to cover code with unit tests. I'd recommend TDD or BDD but you free to choose your way here
  • use jsdocs for all functions

*) We can't use zip (if you need explanation search for storing binaries in git). As well we can't store unzip version of Dialog Flow zip file, because it has ids so we won't be able to fetch Dialog flow structure from dev/draft copy.

❗️ please don't commit secret keys they should come from process.env.

@hyzhak hyzhak added enhancement New feature or request good first issue Good for newcomers labels Mar 15, 2018
hyzhak added a commit that referenced this issue Mar 15, 2018
@savannahar68
Copy link

Thank you so much! Surely helps

@hyzhak hyzhak changed the title how to create dev/draft copy of our Dialog Flow App create instruction of how to create dev/draft copy of our Dialog Flow App and add helpful scripts Mar 15, 2018
@poush
Copy link

poush commented Mar 15, 2018

@hyzhak Can I try this? As far as I understand this, We can make a script which when run on exported zip from Dialogflow will generate a self executable scripts consisting all dump of the zip contents in itself or a separate dump file. Now this generated script or dump can be copied anywhere but I couldn't get the third part here which is basically to deploy DialogFlow app. Is it saying we could be able to generate the zip again which can be imported in the DialogFlow or something else?

@hyzhak hyzhak changed the title create instruction of how to create dev/draft copy of our Dialog Flow App and add helpful scripts Create instruction of how to create dev/draft copy of our Dialog Flow App and add helpful scripts Mar 15, 2018
@hyzhak hyzhak removed the good first issue Good for newcomers label Mar 15, 2018
@bimlendra bimlendra self-assigned this Mar 16, 2018
@bimlendra
Copy link
Collaborator

I am trying to make curl request for "music-XYZ" but server is responding that dialogflow is not enabled in this project & also pretending that I am making request for project "google.com:cloudsdktool". However, dialogflow is already enabled for project "music-XYZ".
Request: curl -X GET -H "Authorization: Bearer "$(gcloud auth print-access-token) -H "Content-Type: application/json; charset=utf-8" "https://dialogflow.googleapis.com/v2beta1/projects/music-XYZ/agent"

Response: {
"error": {
"code": 403,
"message": "Dialogflow API has not been used in project google.com:cloudsdktool before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/dialogflow.googleapis.com/overview?project=google.com:cloudsdktool then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.",
"status": "PERMISSION_DENIED",
"details": [
{
"@type": "type.googleapis.com/google.rpc.Help",
"links": [
{
"description": "Google developers console API activation",
"url": "https://console.developers.google.com/apis/api/dialogflow.googleapis.com/overview?project=google.com:cloudsdktool"
}
]
}
]
}
}

bimlendra pushed a commit that referenced this issue Mar 19, 2018
@hyzhak hyzhak added the project accessibility project accessibility label Mar 19, 2018
@bimlendra
Copy link
Collaborator

@hyzhak : Agent uploading is possible using v2 api. Hence, we will have to upgrade our DialogFlow to v2 version. Before that we need to ensure the impact of this upgradation on our existing agent.

@afirstenberg
Copy link

As an aside - checking in the JSON from the zip file is safe. Although it contains IDs, there is nothing secret about them, and loading it into a different project won't cause any problems. (The v2 API method is just an API for uploading and downloading the zips of these json files.)

@hyzhak
Copy link
Member Author

hyzhak commented Nov 26, 2018

@afirstenberg IDs could be alter by DialogFlow and we would get different json files with different IDs but with the same data.

So possible solution - unzip jsons and strip IDs.

In additional we would like to share Dialog Model between Action of Google and Alexa Skill, as much as possible. Because both app has very high similarity

And Ideally it should be YAML, because it is more human readable than JSON or CSV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request project accessibility project accessibility
Projects
None yet
Development

No branches or pull requests

5 participants