Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an ONIX-bot for Bibliometa data-set #12

Open
2 of 8 tasks
mekarpeles opened this issue Jun 18, 2018 · 0 comments
Open
2 of 8 tasks

Create an ONIX-bot for Bibliometa data-set #12

mekarpeles opened this issue Jun 18, 2018 · 0 comments
Assignees
Labels

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Jun 18, 2018

References internetarchive/openlibrary#860

In addition to the two bug fixes mentioned up top, there are a whole stack of other things that need to be cleaned up since this code hasn't been touched in 9 years. It may even be the case that it's better to use the current code as a specification and reimplement.

Some of the things which I notice at a glance:

  • PEP-8 spaces instead of tabs (Use pycodestyle for this)
  • replace Sax with ElementTree or other modern XML access
  • replace xmltramp.py with a more modern off-the-shelf XML library
  • replace urlcache.py with Requests cache? May be built-in to XML library, so unnecessary
  • replace thread_utils.py with modern built-ins
  • define a custom exception to raise rather than using Exception
  • names are converted to ASCII (ick! perhaps one of the sources of all our broken names)
  • importer works directly against a database instead of using the API
@sbshah97 sbshah97 self-assigned this Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants