You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In addition to the two bug fixes mentioned up top, there are a whole stack of other things that need to be cleaned up since this code hasn't been touched in 9 years. It may even be the case that it's better to use the current code as a specification and reimplement.
Some of the things which I notice at a glance:
PEP-8 spaces instead of tabs (Use pycodestyle for this)
replace Sax with ElementTree or other modern XML access
replace xmltramp.py with a more modern off-the-shelf XML library
replace urlcache.py with Requests cache? May be built-in to XML library, so unnecessary
replace thread_utils.py with modern built-ins
define a custom exception to raise rather than using Exception
names are converted to ASCII (ick! perhaps one of the sources of all our broken names)
importer works directly against a database instead of using the API
The text was updated successfully, but these errors were encountered:
References internetarchive/openlibrary#860
In addition to the two bug fixes mentioned up top, there are a whole stack of other things that need to be cleaned up since this code hasn't been touched in 9 years. It may even be the case that it's better to use the current code as a specification and reimplement.
Some of the things which I notice at a glance:
The text was updated successfully, but these errors were encountered: