Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to "add a new book" when no results are found on the book search page #10049

Closed
Tracked by #9232
RayBB opened this issue Nov 19, 2024 · 5 comments · Fixed by #10123
Closed
Tracked by #9232

Add an option to "add a new book" when no results are found on the book search page #10049

RayBB opened this issue Nov 19, 2024 · 5 comments · Fixed by #10123
Assignees
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Nov 19, 2024

Proposal

When the books search page has no results. We should show an option to "add a new book"
For example: https://openlibrary.org/search?q=%22institutional+thickness+999%22

This is per @cdrini 's suggestion here

Justification

The problem is that when there are no search results we leave the user with nothing to do.
If they're looking for a book and can't find it then we should let them know they can add it.

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 19, 2024
@cdrini cdrini added Priority: 3 Issues that we can consider at our leisure. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 19, 2024
@longbui23
Copy link
Contributor

longbui23 commented Nov 20, 2024

Hi @RayBB,

I'm Long, a member of a group of 5 students in Dickinson College who really want to contribute to Open Library. We're really interested in this issue and want to ask whether you could grant us this issue. Looking forward to your guidance. Thank you!

@RayBB
Copy link
Collaborator Author

RayBB commented Nov 20, 2024

@longbui23 you're assigned now.
Please read the contributing.md (especially watching the technical walkthrough)
Let me know if you have any questions.

Good luck!

@longbui23
Copy link
Contributor

Hello @RayBB , we have successfully implemented a feature that allows users to add a new book when no search results are found, as demonstrated in the video. However, we are uncertain whether we should create a template for this button or feature.

We have thoroughly reviewed all previous files but haven't encountered any similar types of book-adding buttons or features. We would be very grateful if you could advise on the best approach for this functionality.

Screen.Recording.2024-12-03.at.10.37.17.PM.mov

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Dec 4, 2024
@RayBB
Copy link
Collaborator Author

RayBB commented Dec 4, 2024

That looks good. A link like that should work. I don't think it needs to be a button since it's not an action only a navigation.

@cdrini
Copy link
Collaborator

cdrini commented Dec 4, 2024

Nice! Let's go with "Add a new book?" as the markup, and let's put it on the same lane with the other text (adding a period!)

@RayBB RayBB removed the Needs: Response Issues which require feedback from lead label Dec 4, 2024
@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
3 participants