Orphaned editions throw IndexError

[cclauss]

Fixed in #4052

Evidence / Screenshot (if possible)

http://staging.openlibrary.org/books/OL21692921M?debug=true

<class 'IndexError'> at /books/OL21692921M
list index out of range
Python /openlibrary/openlibrary/templates/type/edition/view.html in template, line 9
Web GET http://staging.openlibrary.org/books/OL21692921M

Relevant url?

http://staging.openlibrary.org/books/OL21692921M/Catharisme?debug=true&edition=

Steps to Reproduce

1. Go to ...
2. Do ...

• Actual:
• Expected:

Details

• Logged in (Y/N)?
• Browser type/version?
• Operating system?
• Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

[cdrini]

Updated title; this isn't a Python 3 specific issue

[cclauss]

Fixed in #4052

[cdrini]

Here's the code the edit pages use to create a "dummy" work (not committed to db) to normalize rendering. Note the return type of .new is the Work model in this case.

openlibrary/openlibrary/plugins/upstream/addbook.py

Lines 738 to 746 in b586b90

	if not work:
	# HACK: create dummy work when work is not available
	work = web.ctx.site.new('', {
	'key': '',
	'type': {'key': '/type/work'},
	'title': edition.title,
	'authors': [{'type': {'key': '/type/author_role'}, 'author': {'key': a['key']}} for a in edition.get('authors', [])],
	'subjects': edition.get('subjects', []),
	})

[cclauss]

Fixed in #4286

[seabelis]

Still a problem on some records. https://openlibrary.org/books/OL16161815M/History_of_Chinese_literature.?debug=true

[cdrini]

Created a separate issue for this, since the cause of the error is very different this time 👍 #5404