Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding to lists broken #4586

Closed
seabelis opened this issue Feb 12, 2021 · 2 comments · Fixed by #4591
Closed

Adding to lists broken #4586

seabelis opened this issue Feb 12, 2021 · 2 comments · Fixed by #4591
Assignees
@cdrini
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] Type: Bug Something isn't working. [managed]

Comments

@seabelis
Copy link
Collaborator

Adding an item to a list no longer works as of 12-02-2021.

Evidence / Screenshot (if possible)

Relevant url?

Steps to Reproduce

  1. Go to ...an edition, etc.
  2. Do ...add item to list.
  • Actual: List link loads list page.
  • Expected: Item should be added to list.

Details

  • Logged in (Y/N)? Y
  • Browser type/version? Chrome Version 88.0.4324.150 (Official Build) (x86_64)
  • Operating system? Mac Big Sur
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

@cclauss
@seabelis seabelis added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Feb 12, 2021
@cdrini cdrini added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] and removed Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Feb 12, 2021
@cdrini
Copy link
Collaborator

cdrini commented Feb 12, 2021

Seeing this error in the console:

image

@cdrini cdrini self-assigned this Feb 12, 2021
@cdrini cdrini mentioned this issue Feb 12, 2021
Merged
1 task
@cdrini
Copy link
Collaborator

cdrini commented Feb 12, 2021 •
edited
Loading

The issue was we were using json_encode inside lists/widget.html on an empty list []. The (now reverted) code change caused json_encode([]) to return {}, breaking the JS code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrini cdrini

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Fix Nothing is not JSON serializable" internetarchive/openlibrary
2 participants
@cdrini @seabelis