Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

siteSearch is id but being continuously used in the same page #4619

Closed
ArunTeltia opened this issue Feb 17, 2021 · 2 comments · Fixed by #4624
Closed

siteSearch is id but being continuously used in the same page #4619

ArunTeltia opened this issue Feb 17, 2021 · 2 comments · Fixed by #4624
Labels
Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]

Comments

@ArunTeltia
Copy link
Contributor

Problem : Making code refined,
There are many files where i found id siteSearch, I want to report a file which have more that one instance of it

/openlibrary/templates/stats/readinglog.html

so I want to know if its better to change the id to class or better to create a new class for the readinglog.html file

There are many files with id siteSearch and many files with class siteSearch

I think it will be better to change the id to class with some other name

Stakeholders

@jdlrobson
@ArunTeltia ArunTeltia added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Feb 17, 2021
@mekarpeles mekarpeles added Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] and removed Needs: Lead labels Feb 17, 2021
@jdlrobson
Copy link
Collaborator

jdlrobson commented Feb 17, 2021 •
edited
Loading

I would suggest removing the ID #siteSearch from all HTML and replacing any instances where cSS is styling the #siteSearch selector with .list-books. Best to leave .siteSearch as is for now.

@ArunTeltia
Copy link
Contributor Author

Working on the pr

@ArunTeltia ArunTeltia mentioned this issue Feb 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Id converted to class ArunTeltia/openlibrary
3 participants
@jdlrobson @mekarpeles @ArunTeltia