-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitpod not displaying covers #5834
Comments
@cdrini as far as I can tell, when developing on my local machine the cover images served from local do not work properly. The only covers that load are the ones hosted on archive.org For example, alice in wonderland search doesn't show a cover and links to this cover (which is blank). However, when you click on the work you see a cover hosted on archive.org. All that is to say, I think there is an issue here that needs to be fixed for local development first. Once it's working on local the fix for gitpod should be as simple as adding
Line 19 in 5caa59f
The above solution is getting the gitpod url for port 7075 (where coverstore lives) and setting it in the config yaml. |
Is there a write-up on how to use gitpod with this repo? |
@cclauss all you need to do is click gitpod button in readme and then sign up for an account |
@cclauss For a pull request, prefix the PR url with |
WOW!!! Supercool! |
We should reopen this one as it wasn't actually fixed by the PR above (I should have been more clear). |
Gitpod is rendering pages with
<img src="http://localhost:7075/...">
. These will not work, and should reflect the container url (somehow). This path is specified inopenlibrary.yml
as the covers public url.Steps to Reproduce
Details
Proposal & Constraints
Related files
Stakeholders
@RayBB
The text was updated successfully, but these errors were encountered: