Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitpod not displaying covers #5834

Closed
cdrini opened this issue Nov 8, 2021 · 6 comments · Fixed by #5867 or #9869
Closed

Gitpod not displaying covers #5834

cdrini opened this issue Nov 8, 2021 · 6 comments · Fixed by #5867 or #9869
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 8, 2021

Gitpod is rendering pages with <img src="http://localhost:7075/..."> . These will not work, and should reflect the container url (somehow). This path is specified in openlibrary.yml as the covers public url.

Steps to Reproduce

  1. Go to a search results page ; eg /search?q=the
  • Actual: Covers all broken
  • Expected: covers working, can upload as well.

Details

  • Logged in (Y/N)? N
  • Browser type/version? FF94
  • Operating system? Win10
  • Environment (prod/dev/local)? gitpod

Proposal & Constraints

Related files

Stakeholders

@RayBB

@cdrini cdrini added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 8, 2021
@RayBB
Copy link
Collaborator

RayBB commented Nov 9, 2021

@cdrini as far as I can tell, when developing on my local machine the cover images served from local do not work properly. The only covers that load are the ones hosted on archive.org

For example, alice in wonderland search doesn't show a cover and links to this cover (which is blank). However, when you click on the work you see a cover hosted on archive.org.

All that is to say, I think there is an issue here that needs to be fixed for local development first.

Once it's working on local the fix for gitpod should be as simple as adding

NEW="coverstore_public_url: $(gp url 7075)" && sed -i "s/coverstore_public_url.*/${NEW//\//\\/}/g" config/openlibrary.yml to the command task of the gitpod yaml.

command: docker-compose up

The above solution is getting the gitpod url for port 7075 (where coverstore lives) and setting it in the config yaml.

@cclauss
Copy link
Contributor

cclauss commented Nov 10, 2021

Is there a write-up on how to use gitpod with this repo?

@RayBB
Copy link
Collaborator

RayBB commented Nov 10, 2021

@cclauss all you need to do is click gitpod button in readme and then sign up for an account

@cdrini
Copy link
Collaborator Author

cdrini commented Nov 10, 2021

@cclauss For a pull request, prefix the PR url with gitpod.io/# eg https://gitpod.io/#https://github.com/internetarchive/openlibrary/pull/5851

@cclauss
Copy link
Contributor

cclauss commented Nov 10, 2021

WOW!!! Supercool!

@RayBB
Copy link
Collaborator

RayBB commented Nov 13, 2021

We should reopen this one as it wasn't actually fixed by the PR above (I should have been more clear).

@cclauss cclauss reopened this Nov 14, 2021
@cdrini cdrini added Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Needs: Lead labels Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
3 participants