Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display vendors beneath omnibar on mobile book page views #7009

Closed
Tracked by #6484
jimchamp opened this issue Sep 26, 2022 · 4 comments · Fixed by #7071
Closed
Tracked by #6484

Display vendors beneath omnibar on mobile book page views #7009

jimchamp opened this issue Sep 26, 2022 · 4 comments · Fixed by #7071
Assignees
Labels
Good First Issue Easy issue. Good for newcomers. [managed] hacktoberfest Issues appropriate for Hacktoberfest participants Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Book Page Issues related to the redesign of the books page Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@jimchamp
Copy link
Collaborator

jimchamp commented Sep 26, 2022

On the mobile book page, the vendor section should appear directly beneath the omnibar.

Screenshot from 2022-09-26 19-52-36

In order to achieve this, the existing vendor section should be duplicated and added to the template after the omnibar section. The newly created vendor section should not be displayed while the site has a two-column layout (desktop view). Similarly, the original vendor section should not appear in mobile views.

The vendor section has its own template, here: https://github.com/internetarchive/openlibrary/blob/master/openlibrary/macros/AffiliateLinks.html
It's probably best to pass an optional string to the template containing any additional classes that will be needed to display the correct vendor section. You can add the new classes the the ul element in AffiliateLinks.html.

CSS for the vendor link section can be found here: https://github.com/internetarchive/openlibrary/blob/master/static/css/components/read-panel.less

@jimchamp jimchamp added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Theme: Book Page Issues related to the redesign of the books page labels Sep 26, 2022
@jimchamp jimchamp changed the title Hide vender section on mobile, duplicate under omnibar Display vendors beneath omnibar on mobile book page views Sep 26, 2022
@jimchamp jimchamp added Good First Issue Easy issue. Good for newcomers. [managed] hacktoberfest Issues appropriate for Hacktoberfest participants Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] labels Sep 27, 2022
@ztjhz
Copy link
Contributor

ztjhz commented Sep 27, 2022

I would like to work on this

@jimchamp
Copy link
Collaborator Author

Thanks @ztjhz! Let me know if you have any questions.

@ztjhz
Copy link
Contributor

ztjhz commented Sep 29, 2022

@jimchamp
May I know where the omnibar is at? I do not see it in the book page:

@jimchamp
Copy link
Collaborator Author

This is the omnibar:
Screenshot from 2022-09-29 10-23-25
Mobile view

Screenshot from 2022-09-29 10-22-24
Desktop view

You can find it by searching for an element with class edition-omniline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Easy issue. Good for newcomers. [managed] hacktoberfest Issues appropriate for Hacktoberfest participants Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Book Page Issues related to the redesign of the books page Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants