-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable single-field password entry for email sign-ups #7645
Comments
I have made the changes @beccat123 ,can you check it out. |
I would like to work on this issue. As I am new to open source, can you guide me a little. |
We'll need to add two icons in support of this feature: the "show password" and "hide password" icons. |
Since there is no response and I can't find both show and hide password icons in the Figma, I'm replacing the icon with a string. |
Why not just use the icons from Font Awesome or some other liberally licensed icon library? If FA doesn't work, Wikimedia Commons as an entire page of alternatives to choose from https://commons.wikimedia.org/wiki/Category:SVG_eye_icons |
Please Assign me this issue |
@ayushman075 there is already a PR for this. If you're trying to find a good first issue, check out these search results: https://github.com/internetarchive/openlibrary/issues?q=is%3Aissue+is%3Aopen+-linked%3Apr+label%3A%22Good+First+Issue%22+no%3Aassignee |
Currently, the email sign-up screen asks the user to create their password and re-enter it for confirmation. This results in more labor and therefore cumbersome UX.
Delete the password confirmation field and instead introduce an eye icon within the password entry field that would allow the user to toggle password visibility on and off.
Design details specified in: https://www.figma.com/file/kiaTbWxdPsyqz6eeaT4M8l/Open-Library---Sign-In-Flow?node-id=73%3A4143&t=gm520FiKGEaKFNWJ-1
Screenshot of the Figma frame:
This issue belongs to the epic #7694
Code
Here are the files which may need to be updated:
The text was updated successfully, but these errors were encountered: