Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable single-field password entry for email sign-ups #7645

Closed
Tracked by #7647 ...
beccat123 opened this issue Mar 14, 2023 · 7 comments · Fixed by #7729
Closed
Tracked by #7647 ...

Enable single-field password entry for email sign-ups #7645

beccat123 opened this issue Mar 14, 2023 · 7 comments · Fixed by #7729
Assignees
Labels
Lead: @beccat123 Design issues related to registration & persona research Priority: 3 Issues that we can consider at our leisure. [managed] registration Theme: Design Issues related to UI design, branding, etc. [managed]

Comments

@beccat123
Copy link
Collaborator

beccat123 commented Mar 14, 2023

Currently, the email sign-up screen asks the user to create their password and re-enter it for confirmation. This results in more labor and therefore cumbersome UX.

Delete the password confirmation field and instead introduce an eye icon within the password entry field that would allow the user to toggle password visibility on and off.

Design details specified in: https://www.figma.com/file/kiaTbWxdPsyqz6eeaT4M8l/Open-Library---Sign-In-Flow?node-id=73%3A4143&t=gm520FiKGEaKFNWJ-1

Screenshot of the Figma frame:
Phase 6

This issue belongs to the epic #7694

Code

Here are the files which may need to be updated:

@beccat123 beccat123 added the Theme: Design Issues related to UI design, branding, etc. [managed] label Mar 14, 2023
@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @beccat123 Design issues related to registration & persona research labels Mar 14, 2023
@mekarpeles mekarpeles modified the milestones: 2023 H1, Sprint 2023-03 Mar 14, 2023
@mekarpeles mekarpeles added Good First Issue Easy issue. Good for newcomers. [managed] Needs: Detail Submitter needs to provide more detail for this issue to be assessed (see comments). [managed] and removed Needs: Detail Submitter needs to provide more detail for this issue to be assessed (see comments). [managed] labels Mar 14, 2023
@mekarpeles mekarpeles modified the milestones: Sprint 2023-04, 2023 Mar 21, 2023
@Ari1009
Copy link
Contributor

Ari1009 commented Mar 25, 2023

I have made the changes @beccat123 ,can you check it out.

@zain93393
Copy link

I would like to work on this issue. As I am new to open source, can you guide me a little.

@jimchamp
Copy link
Collaborator

jimchamp commented Dec 5, 2023

We'll need to add two icons in support of this feature: the "show password" and "hide password" icons.
@beccat123 or @mekarpeles, do either of you know where the icon used in the mock-ups was originally found?

@jimchamp
Copy link
Collaborator

Since there is no response and I can't find both show and hide password icons in the Figma, I'm replacing the icon with a string.

@tfmorris
Copy link
Contributor

Why not just use the icons from Font Awesome or some other liberally licensed icon library? If FA doesn't work, Wikimedia Commons as an entire page of alternatives to choose from https://commons.wikimedia.org/wiki/Category:SVG_eye_icons

@ayushman075
Copy link

Please Assign me this issue

@jimchamp jimchamp self-assigned this Dec 25, 2023
@jimchamp
Copy link
Collaborator

@ayushman075 there is already a PR for this.

If you're trying to find a good first issue, check out these search results: https://github.com/internetarchive/openlibrary/issues?q=is%3Aissue+is%3Aopen+-linked%3Apr+label%3A%22Good+First+Issue%22+no%3Aassignee

@jimchamp jimchamp removed the Good First Issue Easy issue. Good for newcomers. [managed] label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @beccat123 Design issues related to registration & persona research Priority: 3 Issues that we can consider at our leisure. [managed] registration Theme: Design Issues related to UI design, branding, etc. [managed]
Projects
None yet
7 participants