Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Library Team Page #7650

Closed
mekarpeles opened this issue Mar 15, 2023 · 2 comments · Fixed by #8437
Closed

Open Library Team Page #7650

mekarpeles opened this issue Mar 15, 2023 · 2 comments · Fixed by #8437
Assignees
@Lasseignejk
Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Epic A feature or refactor that is big enough to require subissues. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Mar 15, 2023 •
edited
Loading

Describe the problem that you'd like solved

A basic team page design for https://openlibrary.org/about/people

Designs:
https://www.figma.com/proto/8MoiibMFcYHI3djoiiFmWP/Meet-the-Staff-2?node-id=206%3A244&scaling=min-zoom&page-id=206%3A213&starting-point-node-id=206%3A244

Screenshot 2023-03-14 at 7 43 39 PM

Important files & next steps

Here is an example of how to register a new route with Open Library (i.e. how to define or override an endpoint like /about/people:
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/plugins/openlibrary/authors.py

We'll also need to add a new file to our templates/ directory -- /about/people.html in:
https://github.com/internetarchive/openlibrary/tree/master/openlibrary/templates

Relevant resources
@mekarpeles mekarpeles added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Epic A feature or refactor that is big enough to require subissues. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] labels Mar 15, 2023
@Lasseignejk
Copy link
Contributor

I'd like to work on this issue!

@mekarpeles
Copy link
Member Author

@Lasseignejk please do! Do you have any questions or need any help with next steps?

@Lasseignejk Lasseignejk mentioned this issue Apr 25, 2023
Merged
@Eds-Dbug Eds-Dbug mentioned this issue Sep 27, 2023
Closed
@Lasseignejk Lasseignejk mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lasseignejk Lasseignejk

Labels
Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Epic A feature or refactor that is big enough to require subissues. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added filtering to team page Lasseignejk/openlibrary
Refactor team.json Eds-Dbug/openlibrary
2 participants
@mekarpeles @Lasseignejk