Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible reCaptcha #7674

Closed
Tracked by #4485 ...
mekarpeles opened this issue Mar 16, 2023 · 1 comment · Fixed by #8258
Closed
Tracked by #4485 ...

Invisible reCaptcha #7674

mekarpeles opened this issue Mar 16, 2023 · 1 comment · Fixed by #8258
Assignees
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 2 Important, as time permits. [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Mar 16, 2023

We use recaptcha in a number of places throughout the site. archive.org uses an Invisible recatpcha, which does not prompt the user unless it detect suspicious activity -- we've decided to follow suit.

https://developers.google.com/recaptcha/docs/invisible

Checklist

  1. The invisible reCAPTCHA requires new keys, so we'll need a new entry in openlibrary.yml for the keys. Name the new entry plugin_invisible_recaptcha, and model the entry after the existing plugin_recaptcha entry (with empty strings as the key values).
  2. Update the registration form handler to use the new keys. These keys are set in the get_recap function, here.
  3. Make the following updates to the account registration template (here):
  • Remove the existing reCAPTCHA, and related copy
  • Add the g-recaptcha class to the submit button
  • Add data-sitekey to the submit button. If the form has a reCAPTCHA, use the new public key as the value. Otherwise, use an empty string.
  1. Update the existing submission button click handler, here, to programmatically invoke the reCAPTCHA challenge. Form submission should not be triggered if the challenge was failed.
@mekarpeles mekarpeles mentioned this issue Mar 16, 2023
15 tasks
@cdrini cdrini added this to the 2023 milestone Mar 17, 2023
@cdrini cdrini added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Mar 17, 2023
@imlakshay08
Copy link

Hey @mekarpeles , could you assign this task to me please? I would like to work on this issue.

@mekarpeles mekarpeles added registration Priority: 2 Important, as time permits. [managed] Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] Affects: Experience Issues relating directly to service design & patrons experience and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Mar 21, 2023
This was referenced Mar 21, 2023
@internetarchive internetarchive deleted a comment from jimchamp Jul 26, 2023
@mekarpeles mekarpeles added the Good First Issue Easy issue. Good for newcomers. [managed] label Jul 26, 2023
@mekarpeles mekarpeles added Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Lead: @mekarpeles Issues overseen by Mek (Staff: Program Lead) [managed] labels Sep 15, 2023
@mekarpeles mekarpeles modified the milestones: 2023, Sprint 2023-11 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 2 Important, as time permits. [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
4 participants