Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search result items borrow status should reflect user's actions (e.g. waitlist, borrow) #781

Closed
mekarpeles opened this issue Jan 31, 2018 · 1 comment
Labels
Affects: UI Issues with the web site's user interface. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]

Comments

@mekarpeles
Copy link
Member

Open Library has a broken understanding of what books are readable.

  1. Open library is behind because solr takes so long to index and often breaks/aborts during updates
  2. Open Library doesn't distinguish between daisy-only results (i.e. books which can only be read by the print-disabled) and books which can be read/borrowed by anyone.

As a result, when ebooks mode is selected on Openlibrary.org /search, we make ajax calls to Archive.org's Availability v2 API to fetch filter out daisy-only books and to paint the UI with the correct availability information.

This causes an annoying flicker in the UI which is described in #733 and should be addressed by moving this availability check + filtering to the backend in /plugins/worksearch/code.

This issue addresses another externality of these circumstances, that the search/ results UI is not being updated to reflect users' position on waitlists / borrow status. e.g. if a user clicks "join waitlist" from the search results page, and then the user does the same search, the UI will still show "join waitlist" instead of saying, e.g. "You are next on the waitlist"

@mekarpeles mekarpeles added Type: Bug Something isn't working. [managed] Theme: Search Issues related to search UI and backend. [managed] ui labels Jan 31, 2018
@mekarpeles
Copy link
Member Author

resolved via #995 (at least for the search results page -- suggesting this pattern be followed elsewhere)

@brad2014 brad2014 added the Affects: UI Issues with the web site's user interface. [managed] label May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: UI Issues with the web site's user interface. [managed] Theme: Search Issues related to search UI and backend. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

2 participants