Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodreads import fails if data contains a custom shelf #8158

Closed
seabelis opened this issue Aug 4, 2023 · 2 comments · Fixed by #8306
Closed

Goodreads import fails if data contains a custom shelf #8158

seabelis opened this issue Aug 4, 2023 · 2 comments · Fixed by #8306
Assignees
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]

Comments

@seabelis
Copy link
Collaborator

seabelis commented Aug 4, 2023

Goodreads allows custom exclusive shelves in addition to the three standard read/want to read/currently reading shelves. If a patron has a custom exclusive shelf and tries to import their data, the import halts when it hits one of these rows.

Evidence / Screenshot (if possible)

Screenshot 2023-08-04 at 11 08 24

Relevant url?

https://openlibrary.org/account/import/goodreads

Related to #7925

Steps to Reproduce

  1. Go to ... import options.
  2. Do ... try to import Goodreads data containing a custom exclusive shelf.
  • Actual: import halts
  • Expected: Those rows should skipped with a warning to the patron.

Details

  • Logged in (Y/N)?
  • Browser type/version?
  • Operating system?
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Custom shelves need to be handled in some way, or allow patron to skip them.

Related files

Stakeholders

@seabelis seabelis added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Affects: Experience Issues relating directly to service design & patrons experience Needs: Lead labels Aug 4, 2023
@mekarpeles
Copy link
Member

I think at minimum, the desired behavior is to skip these records and to continue proceeding through the next compatible shelves. In the future, we could decide to turn these custom shelves into lists but maybe for simplicity (for now) it should just skip and be robust to these cases.

@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Aug 7, 2023
@mekarpeles mekarpeles added the Good First Issue Easy issue. Good for newcomers. [managed] label Sep 15, 2023
@akhil-rasheed
Copy link
Contributor

Hi, I'd like to take up this issue. New to the community and this seems like a good first issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants