Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalidate dates from editions during create/edit (e.g. 9999) #8351

Closed
mekarpeles opened this issue Oct 2, 2023 · 1 comment · Fixed by #8367
Closed

Remove invalidate dates from editions during create/edit (e.g. 9999) #8351

mekarpeles opened this issue Oct 2, 2023 · 1 comment · Fixed by #8367
Assignees
@mekarpeles
Labels
Lead: @scottbarnes Issues overseen by Scott (Community Imports) Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Bug Something isn't working. [managed]
Milestone
Sprint 2023-10

Comments

@mekarpeles
Copy link
Member

Evidence / Screenshot (if possible)

Proposing somewhere in catalog that we prevent any record from having future dates (may be most applicable to BWB / promise items)
https://github.com/internetarchive/openlibrary/blob/master/openlibrary/catalog/add_book/__init__.py#L740

Relevant url?

Steps to Reproduce

  1. Go to ...
  2. Do ...
  • Actual:
  • Expected:

Details

  • Logged in (Y/N)?
  • Browser type/version?
  • Operating system?
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders
@mekarpeles mekarpeles added Type: Bug Something isn't working. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Lead: @scottbarnes Issues overseen by Scott (Community Imports) labels Oct 2, 2023
@mekarpeles mekarpeles added this to the Sprint 2023-10 milestone Oct 2, 2023
@mekarpeles mekarpeles mentioned this issue Oct 4, 2023
Merged
2 tasks
@mekarpeles mekarpeles self-assigned this Oct 5, 2023
@mekarpeles
Copy link
Member Author

Also, retroactively we wanted to cleanup things with future dates and here's the query:
https://openlibrary.org/search?q=publish_year%3A%5B2025+TO+*%5D

It looks like @hornc has done this for the 9999 cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mekarpeles mekarpeles

Labels
Lead: @scottbarnes Issues overseen by Scott (Community Imports) Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
Sprint 2023-10
Development

Successfully merging a pull request may close this issue.

Fix promise future dates internetarchive/openlibrary
1 participant
@mekarpeles