Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Open Library Search Tips" link to advanced search page #8400

Closed
RayBB opened this issue Oct 8, 2023 · 9 comments · Fixed by #8429
Closed

Add "Open Library Search Tips" link to advanced search page #8400

RayBB opened this issue Oct 8, 2023 · 9 comments · Fixed by #8429
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Oct 8, 2023

Describe the problem that you'd like solved

I was looking for this page but it was hard to find https://openlibrary.org/search/howto
I think it would be nice if we added a link to it on https://openlibrary.org/advancedsearch

PS: I already added a link to it on the help page https://openlibrary.org/help.en

Proposal & Constraints

Additional context

https://github.com/internetarchive/openlibrary/blob/master/openlibrary/templates/search/advancedsearch.html

Stakeholders

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead Good First Issue Easy issue. Good for newcomers. [managed] labels Oct 8, 2023
@piyush-poddar
Copy link
Contributor

@RayBB Can you please specify exactly where should the link be added?
Should it be on the bottom of 'Advanced Search'?

@RayBB
Copy link
Collaborator Author

RayBB commented Oct 9, 2023

@piyush-poddar it is to be discussed. Feel free to make a proposal of what you think would look good and work well.
You may also try to find another example somewhere on the site and follow that.

@piyush-poddar
Copy link
Contributor

@RayBB I think the link should be on the bottom of 'Advanced Search' as it is a helping link, so users will find it handy if they need any help in searching. What are your thoughts on this?

@RayBB
Copy link
Collaborator Author

RayBB commented Oct 9, 2023

@RayBB something like that is sounds good to me. Be aware that I'm just a volunteer so don't have the final say on anything and getting community input (usually via slack or the community call) is how things are usually decided. However, for something simple like this starting with a PR and discussing it there seems fine. I think we will want a link it's just a question of where on the page and what it should say.

@piyush-poddar
Copy link
Contributor

@RayBB Okay, then I'll open a PR after sometime.
Thanks for your input.

@mudit-loya
Copy link
Contributor

Hello.
Is this issue still open?

@RayBB
Copy link
Collaborator Author

RayBB commented Oct 13, 2023

@piyush-poddar are you still working on this?

@imperial-chief, as you can see Piyush is assigned to this but hasn't replied in a few days. You can open a PR if you like but we'll prioritize Piyush's if they open one at the same time. Worse case is that it's a good learning experience :)

@mudit-loya
Copy link
Contributor

Yes sure.
But in case, if i open a PR first, will it be considered?

@piyush-poddar
Copy link
Contributor

@RayBB I am quite engaged in some college stuff. You can go on with @imperial-chief PR if it resolves the issue successfully. If not, then I'll open a PR next week.

@mekarpeles mekarpeles added Priority: 3 Issues that we can consider at our leisure. [managed] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Help Issues, typically substantial ones, that need a dedicated developer to take them on. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants