Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikisource Trusted Book Provider #8545

Closed
3 tasks done
cdrini opened this issue Nov 20, 2023 · 5 comments · Fixed by #9659
Closed
3 tasks done

Wikisource Trusted Book Provider #8545

cdrini opened this issue Nov 20, 2023 · 5 comments · Fixed by #9659
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Trusted Book Providers Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 20, 2023

Proposal & Related Files

Follow the template in https://github.com/internetarchive/openlibrary/pull/8682/files ; except for wikisource!

@cdrini cdrini added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Theme: Trusted Book Providers labels Nov 20, 2023
@cdrini cdrini mentioned this issue Nov 20, 2023
53 tasks
@Freso
Copy link
Contributor

Freso commented Dec 12, 2023

FWIW, any item in Wikisource (and any other Wikimedia projects) willshould have a Wikidata item, so it might be enough to add the WD identifier and then get additional information (such as Wikimedia links) from that?

I don’t know enough about your code and data structures to know if that’s feasible for OL, but that’s generally how MusicBrainz and BookBrainz deals with e.g. getting Wikipedia excerpts.

Edit: It seems like not all do, though I believe it is the goal for all of them to have WD item… but I’m not familiar enough with Wikisource specifically to know if there’s maybe an exception there. So maybe either disregard this entire comment or consider allowing for Wikisource identifiers for cases where there’s no WD item. (That’s how we did in MB when WD was new and not all Wikipedia articles had WD items, but we knew that WD items for all WP articles was the goal.)

@bicolino34
Copy link
Collaborator

Some of the editors in Ukrainian Wikisource showed interest to this project. Specifically, to the potential traffic from this.
I am slowly adding IDs to the Ukrainian editions. Hope this will soon be implemented

@bicolino34
Copy link
Collaborator

FWIW, any item in Wikisource (and any other Wikimedia projects) will_should_ have a Wikidata item, so it might be enough to add the WD identifier and then get additional information (such as Wikimedia links) from that?

I don’t know enough about your code and data structures to know if that’s feasible for OL, but that’s generally how MusicBrainz and BookBrainz deals with e.g. getting Wikipedia excerpts.

Edit: It seems like not all do, though I believe it is the goal for all of them to have WD item… but I’m not familiar enough with Wikisource specifically to know if there’s maybe an exception there. So maybe either disregard this entire comment or consider allowing for Wikisource identifiers for cases where there’s no WD item. (That’s how we did in MB when WD was new and not all Wikipedia articles had WD items, but we knew that WD items for all WP articles was the goal.)

@Freso Wikidata items are not very reliable for wikilinks. There is often conflation for Wikisource pages: one language page can point to a version page, which lists all the available editions of a certain work, while the other might be pointing to a specific edition.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Jun 6, 2024
@pidgezero-one
Copy link
Contributor

I'll take this one on after our discussion earlier, @cdrini ! Thank you!

@cdrini
Copy link
Collaborator Author

cdrini commented Jun 12, 2024

Awesome thank you @pidgezero-one !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Trusted Book Providers Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants