Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certbot flow causing covers to error on startup #8809

Closed
cdrini opened this issue Feb 9, 2024 · 0 comments · Fixed by #8847
Closed

Certbot flow causing covers to error on startup #8809

cdrini opened this issue Feb 9, 2024 · 0 comments · Fixed by #8847
Assignees
@cdrini
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Bug Something isn't working. [managed]
Milestone
Sprint 2024-02

Comments

@cdrini
Copy link
Collaborator

cdrini commented Feb 9, 2024 •
edited
Loading

The certbot/letsencrypt flow we added isn't working on covers for a few reasons:

  1. certbot certonly asks for email and stuff first time its run. We need to add some more flags to avoid that
  2. covers doesn't have a /static directory (I don't think?), so can't serve the certbot verification thing
  3. public_nginx.conf links to /etc/letsencrypt/live/openlibrary.org ; we need to make that configurable somehow

P1, blocking deploys until resolved.

Proposal & Constraints

Related files

Stakeholders

@mekarpeles
@cdrini cdrini added Type: Bug Something isn't working. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Feb 9, 2024
@cdrini cdrini self-assigned this Feb 9, 2024
@cdrini cdrini changed the title Letsencrypt flow causing covers to error Letsencrypt flow causing covers to error on startup Feb 9, 2024
@cdrini cdrini changed the title Letsencrypt flow causing covers to error on startup Cerbot flow causing covers to error on startup Feb 9, 2024
@cdrini cdrini changed the title Cerbot flow causing covers to error on startup Certbot flow causing covers to error on startup Feb 9, 2024
@cdrini cdrini added this to the Sprint 2024-02 milestone Feb 26, 2024
@cdrini cdrini mentioned this issue Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrini cdrini

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
Sprint 2024-02
Development

Successfully merging a pull request may close this issue.

Fix covers nginx wrong certbot init cdrini/openlibrary
1 participant
@cdrini