Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typehints to some code #9117

Closed
RayBB opened this issue Apr 19, 2024 · 0 comments · Fixed by #9116
Closed

add typehints to some code #9117

RayBB opened this issue Apr 19, 2024 · 0 comments · Fixed by #9116
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Apr 19, 2024

Problem

Sometimes I think I open a PR like #9116 and it gets lost because it doesn't have an issue. As such, I'm creating this issue.

I was digging around in the code for some reason or other and hit an area missing a lot of typehints so I added them where I could. I only added them in places where I was quite certain based on how they the values were being used.

Context

I now see this is related to #8028

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders

@RayBB RayBB added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant