Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove inline js from openlibrary/templates/site/head.html #9176

Closed
Tracked by #4474
RayBB opened this issue Apr 28, 2024 · 0 comments · Fixed by #9177
Closed
Tracked by #4474

remove inline js from openlibrary/templates/site/head.html #9176

RayBB opened this issue Apr 28, 2024 · 0 comments · Fixed by #9177
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.

Comments

@RayBB
Copy link
Collaborator

RayBB commented Apr 28, 2024

part of #4474
(to be done last when window.q is no longer necessary)

As far as I can tell, window.q isn't used anywhere. If it is, it is very well hidden.
This was referenced Apr 28, 2024
Closed
Merged
@RayBB RayBB added Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove inline.js from head.html and footer.html internetarchive/openlibrary
1 participant
@RayBB