Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Client-Side Submission Prevention for Registration Form #9205

Closed
2 tasks done
Tracked by #7694
rebecca-shoptaw opened this issue May 1, 2024 · 1 comment
Closed
2 tasks done
Tracked by #7694
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Primary Focus The active main quest of this contributor Priority: 2 Important, as time permits. [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]

Comments

@rebecca-shoptaw
Copy link
Collaborator

rebecca-shoptaw commented May 1, 2024

Dependency to epic #7694.

Describe the problem that you'd like solved

While the real-time validation fixes in #2055 will provide helpful error messages to the user re: bad formatting or taken emails, etc., they do not prevent the user from submitting a form with bad data.

For instance, if a user sees a warning that their username is too short, they will now get a nice on-screen warning, but if they choose to submit anyway, they will be able to, and duplicated and inefficient validation will happen on the backend (via forms.py) .

Instead, we should use a combination of HTML and JavaScript to prevent a user from submitting any form that contains bad or missing inputs.

Requirements

Additional context

Stakeholders

@cdrini

@rebecca-shoptaw rebecca-shoptaw added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] registration Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels May 1, 2024
@rebecca-shoptaw rebecca-shoptaw self-assigned this May 1, 2024
@rebecca-shoptaw rebecca-shoptaw changed the title Implement client-side submission prevention for registration form Implement Client-Side Submission Prevention for Registration Form May 1, 2024
@mekarpeles mekarpeles added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Lead labels May 6, 2024
@mekarpeles mekarpeles added Priority: 2 Important, as time permits. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels May 13, 2024
@rebecca-shoptaw rebecca-shoptaw added the Primary Focus The active main quest of this contributor label May 13, 2024
@jimchamp jimchamp added Needs: Review Assignee Issues that may have been abandoned by assignees Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] registration Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] and removed Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] registration Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] Priority: 2 Important, as time permits. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Primary Focus The active main quest of this contributor Needs: Review Assignee Issues that may have been abandoned by assignees labels May 28, 2024
@jimchamp jimchamp added Priority: 2 Important, as time permits. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Primary Focus The active main quest of this contributor labels May 28, 2024
@rebecca-shoptaw
Copy link
Collaborator Author

All subtasks completed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Primary Focus The active main quest of this contributor Priority: 2 Important, as time permits. [managed] registration Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed]
Projects
None yet
Development

No branches or pull requests

3 participants