Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import endpoint should allow for Open Library author identifiers #9411

Open
Freso opened this issue Jun 7, 2024 · 0 comments · May be fixed by #10110
Open

Import endpoint should allow for Open Library author identifiers #9411

Freso opened this issue Jun 7, 2024 · 0 comments · May be fixed by #10110
Labels
Lead: @scottbarnes Issues overseen by Scott (Community Imports) Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] python Pull requests that update Python code Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@Freso
Copy link
Contributor

Freso commented Jun 7, 2024

Problem

A clear and concise description of what you want to happen

Provide Open Library OL…A Author identifiers when importing Editions if the importer has already otherwise dealt with the matching (e.g., using other identifiers).

Expected behaviour / screenshots

Additional Context

Proposal & Constraints

What is the proposed solution / implementation?

Is there a precedent of this approach succeeding elsewhere?

MusicBrainz’ seeding pages allow for MBIDs to pre‐seed relevant fields. (E.g., if seeding a Release page, you can provide MBIDs for artists, release group, recordings, label, …) I’m sure there are other cases too. It doesn’t seem like a very novel idea. 😂

Which suggestions or requirements should be considered for how feature needs to appear or be implemented?

  • Multiple identifiers should be accepted for multiple authors
  • It should allow a mix of identifiers and unidentified names (e.g., for cases where some but not all authors could be identified as already existing in OL)
  • It should probably only accept one or the other per author entry
    • Alternatively, if name and OL…A id(s) are both specified, the name should be disregarded if the OL…A id is valid, but could be used as a fallback if the OL…A id is not valid (e.g., has been deleted entirely or something). (MusicBrainz, BookBrainz, and Wikidata at least keep references to old OL identifiers around, and if an OL entry somehow got deleted entirely rather than merged, that might cause an invalid OL…A assignment, possibly?)

Leads

Related files

Stakeholders

Note: Before making a new branch or updating an existing one, please ensure your branch is up to date.

@Freso Freso added Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] labels Jun 7, 2024
@mekarpeles mekarpeles added Lead: @scottbarnes Issues overseen by Scott (Community Imports) and removed Needs: Lead labels Jun 10, 2024
@scottbarnes scottbarnes added Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Priority: 2 Important, as time permits. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jun 10, 2024
@Freso Freso changed the title Import endpoint should allow for author identifiers Import endpoint should allow for Open Library author identifiers Jun 18, 2024
@scottbarnes scottbarnes added Priority: 3 Issues that we can consider at our leisure. [managed] python Pull requests that update Python code and removed Priority: 2 Important, as time permits. [managed] labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @scottbarnes Issues overseen by Scott (Community Imports) Module: Import Issues related to the configuration or use of importbot and other bulk import systems. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] python Pull requests that update Python code Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants