support comma separated author merge url #10114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayBB
changed the title
cdrini
approved these changes
Dec 4, 2024
|
@cdrini does that remove a trailing comma? If there's a trailing comma it'll give an error because the ID is a " " and invalid ? |
|
^ Yep exactly! |
|
Tested merging from search results, and successfully completed a full merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10113
The purpose of this is to make it easier to add IDs to the author merge page (per the issue)
Technical
Testing
http://localhost:8080/authors/merge?records=OL18319A,OL2180017A,OL3116644A,OL22122A works
So does
http://localhost:8080/authors/merge?key=OL20585A&key=OL18319A (with a redirect)
Screenshot
Stakeholders