From 221012f8f4aad7f2ecebf62a1e316bd19a88efe5 Mon Sep 17 00:00:00 2001 From: Yash Saravgi Date: Sat, 9 Jan 2021 09:21:29 +0530 Subject: [PATCH 1/5] Fixed edition-header h3 spacing --- openlibrary/templates/type/edition/view.html | 14 +++++++------- static/css/components/work.less | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/openlibrary/templates/type/edition/view.html b/openlibrary/templates/type/edition/view.html index 00698fce8b4..eef504c79ad 100644 --- a/openlibrary/templates/type/edition/view.html +++ b/openlibrary/templates/type/edition/view.html @@ -339,13 +339,13 @@


$if edition.first_sentence:
-

$_("First Sentence")

+

$_("First Sentence")

"$(edition.first_sentence)"

$if edition.description:
-

$_("Edition Description")

+

$_("Edition Description")

$:sanitize(format(edition.description)) @@ -360,7 +360,7 @@

$_("Edition Description")

$if edition.notes or edition.series or edition.volume or edition.genres or edition.other_titles or edition.copyright_date or edition.translation_of or edition.translated_from:
-

$_("Edition Notes") +

$_("Edition Notes")

$if edition.notes: $:format(edition.notes) @@ -378,7 +378,7 @@

$_("Edition Notes") $ classifications = edition.get_classifications().multi_items() $if classifications:
-

$_("Classifications")

+

$_("Classifications")

$for name, values in classifications: $:display_identifiers(values[0].label, values) @@ -403,7 +403,7 @@

$ contributors = edition.get('contributors', []) $if contributors:
-

$_("Contributors")

+

$_("Contributors")

$for c in contributors: $:display_value(c.role, c.name) @@ -412,7 +412,7 @@

$_("Contributors")

$if has_any("physical_format", "pagination", "physical_dimensions", "weight"):
-

$_("The Physical Object")

+

$_("The Physical Object")

$:display_value(_("Format"), edition.physical_format) $:display_value(_("Pagination"), edition.pagination) @@ -424,7 +424,7 @@

$_("The Physical Object")

-

$_("ID Numbers")

+

$_("ID Numbers")

$:display_identifiers("Open Library", [storage(url=None, value=edition.key.split("/")[-1])]) $for name, values in edition.get_identifiers().multi_items(): diff --git a/static/css/components/work.less b/static/css/components/work.less index c301eeefcca..389f658879f 100644 --- a/static/css/components/work.less +++ b/static/css/components/work.less @@ -29,7 +29,7 @@ // Center (editionAbout) div.editionAbout { margin-bottom: 20px; - h3 { + h3.edition-header { font-size: 14px; margin: 0 0 0em; } From a40f128b35db7a7ace871233a9e9520ee4eeadfb Mon Sep 17 00:00:00 2001 From: Yash Saravgi Date: Sat, 9 Jan 2021 23:17:50 +0530 Subject: [PATCH 2/5] minor fix --- static/css/components/work.less | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/static/css/components/work.less b/static/css/components/work.less index 389f658879f..f9b16291892 100644 --- a/static/css/components/work.less +++ b/static/css/components/work.less @@ -29,7 +29,7 @@ // Center (editionAbout) div.editionAbout { margin-bottom: 20px; - h3.edition-header { + h3 { font-size: 14px; margin: 0 0 0em; } @@ -96,6 +96,11 @@ vertical-align: middle; font-size: .8em; } +h3.edition-header { + font-size: 14px; + margin: 0 0 0em; +} + h2.edition-byline { margin: 7px 2px 20px; } From 054801dbff2f7914e458681c2283b7d1aba1c7a5 Mon Sep 17 00:00:00 2001 From: Yash Saravgi Date: Sat, 9 Jan 2021 23:21:17 +0530 Subject: [PATCH 3/5] final fix :) --- static/css/components/work.less | 5 ----- 1 file changed, 5 deletions(-) diff --git a/static/css/components/work.less b/static/css/components/work.less index f9b16291892..18f965bc0e5 100644 --- a/static/css/components/work.less +++ b/static/css/components/work.less @@ -29,11 +29,6 @@ // Center (editionAbout) div.editionAbout { margin-bottom: 20px; - h3 { - font-size: 14px; - margin: 0 0 0em; - } - p { margin: 1em 0; font-size: 13px; From f0541b841838d0d52153f05b4328c113d0a64d53 Mon Sep 17 00:00:00 2001 From: Yash Saravgi Date: Sat, 9 Jan 2021 23:56:48 +0530 Subject: [PATCH 4/5] minor fix --- openlibrary/templates/type/edition/view.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/openlibrary/templates/type/edition/view.html b/openlibrary/templates/type/edition/view.html index eef504c79ad..d7e6525f1d3 100644 --- a/openlibrary/templates/type/edition/view.html +++ b/openlibrary/templates/type/edition/view.html @@ -412,7 +412,7 @@

$_("Contributors")

$if has_any("physical_format", "pagination", "physical_dimensions", "weight"):
-

$_("The Physical Object")

+

$_("The Physical Object")

$:display_value(_("Format"), edition.physical_format) $:display_value(_("Pagination"), edition.pagination) @@ -424,7 +424,7 @@

$_("The Physical Object")

-

$_("ID Numbers")

+

$_("ID Numbers")

$:display_identifiers("Open Library", [storage(url=None, value=edition.key.split("/")[-1])]) $for name, values in edition.get_identifiers().multi_items(): From c3f09092cbbd96bd5c12509d2c3e88280713d3aa Mon Sep 17 00:00:00 2001 From: Yash Saravgi Date: Sat, 9 Jan 2021 23:58:31 +0530 Subject: [PATCH 5/5] minor fix --- openlibrary/templates/type/edition/view.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openlibrary/templates/type/edition/view.html b/openlibrary/templates/type/edition/view.html index d7e6525f1d3..6d56f45eb3c 100644 --- a/openlibrary/templates/type/edition/view.html +++ b/openlibrary/templates/type/edition/view.html @@ -378,7 +378,7 @@

$_("Edition Notes") $ classifications = edition.get_classifications().multi_items() $if classifications:
-

$_("Classifications")

+

$_("Classifications")

$for name, values in classifications: $:display_identifiers(values[0].label, values)