From d7a41c693fea29ac74a5a47ec7d2b7623c909378 Mon Sep 17 00:00:00 2001 From: Raymond Berger Date: Sat, 19 Mar 2022 11:01:22 -0400 Subject: [PATCH 1/3] disable infobase ports for local development --- docker-compose.override.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/docker-compose.override.yml b/docker-compose.override.yml index 51d75c4ecf9..e0d53f7f053 100644 --- a/docker-compose.override.yml +++ b/docker-compose.override.yml @@ -67,8 +67,10 @@ services: build: context: . dockerfile: docker/Dockerfile.oldev - ports: - - 7000:7000 + # Commented out because not needed for most dev work + # See https://github.com/internetarchive/openlibrary/issues/6315 + # ports: + # - 7000:7000 volumes: - ol-vendor:/openlibrary/vendor - .:/openlibrary From e55454aa8d6e62f9105ea5b1500ff5d049be7898 Mon Sep 17 00:00:00 2001 From: Drini Cami Date: Mon, 21 Mar 2022 12:39:10 -0400 Subject: [PATCH 2/3] Update docker-compose.override.yml --- docker-compose.override.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docker-compose.override.yml b/docker-compose.override.yml index e0d53f7f053..b76229e3b88 100644 --- a/docker-compose.override.yml +++ b/docker-compose.override.yml @@ -67,7 +67,10 @@ services: build: context: . dockerfile: docker/Dockerfile.oldev - # Commented out because not needed for most dev work + # Commented out because not needed for most dev work, and 7000 conflicts + # with OS port on Mac. Uncomment if you need to test infobase directly. + # Mac users can do eg "7070:7000" to change the por tused on the host + # machine to avoid conflicts. # See https://github.com/internetarchive/openlibrary/issues/6315 # ports: # - 7000:7000 From 778c07539ff120a8fad788683391f305ad153ad9 Mon Sep 17 00:00:00 2001 From: Drini Cami Date: Mon, 21 Mar 2022 12:40:04 -0400 Subject: [PATCH 3/3] Update docker-compose.override.yml --- docker-compose.override.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker-compose.override.yml b/docker-compose.override.yml index b76229e3b88..23789d51c8c 100644 --- a/docker-compose.override.yml +++ b/docker-compose.override.yml @@ -69,7 +69,7 @@ services: dockerfile: docker/Dockerfile.oldev # Commented out because not needed for most dev work, and 7000 conflicts # with OS port on Mac. Uncomment if you need to test infobase directly. - # Mac users can do eg "7070:7000" to change the por tused on the host + # Mac users can do eg "7070:7000" to change the port used on the host # machine to avoid conflicts. # See https://github.com/internetarchive/openlibrary/issues/6315 # ports: