Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that ActionController::Parameters is not handled as Hash subclass #1519

Closed
karlerikounapuu opened this issue Feb 6, 2020 · 1 comment
Assignees

Comments

@karlerikounapuu
Copy link
Member

From Rails 5.1, ActionController::Parameters isn't subclass of Hash anymore. To prevent further similar issues such as #1516 , rest of codebase should be checked also for similar pitfalls.

@karlerikounapuu karlerikounapuu changed the title Verify that ActionController::Parameters is not used as Hash subclass Verify that ActionController::Parameters is not handled as Hash subclass Feb 6, 2020
@yulgolem yulgolem self-assigned this Feb 7, 2020
@yulgolem
Copy link
Contributor

yulgolem commented Feb 7, 2020

Cannot find any occurrences of direct using of old-fashioned params in the model code. That's doesn't mean there is no any, so I suppose we shouldn't close this one yet, just use this issue for future PRs if any.
Let's return to this, say, after a month or so.

@yulgolem yulgolem closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants