Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registrar prefix on contact info and check requests #1832

Closed
vohmar opened this issue Feb 3, 2021 · 0 comments · Fixed by #1835
Closed

Registrar prefix on contact info and check requests #1832

vohmar opened this issue Feb 3, 2021 · 0 comments · Fixed by #1835
Assignees
Labels
enhancement Tests prepared TDD: autotests prepared

Comments

@vohmar
Copy link
Contributor

vohmar commented Feb 3, 2021

On contact create registrar specific prefix is added to any created contact id unless already present in the create request.

For example a registrar with code TEST will get TEST: prefix in front of any contact created ie creating contact with id 123 will results with an object that has id of TEST:123. This is also reported in the response message and is so to provide uniqueness of the codes.

At the same time on queries the code entered by the registrar is used as is. So if for example the same registrar would look for an object with id 123 the response would be not found creating confusion as create request will end with object already exists.

To fix this we should add the prefix check to these kind of queries as well if no valid prefix is already present. The difference here to keep in mind is that registrar could also look for objects belonging to other registrars so the prefix check should be done against the pool of existing registrar codes. Also there are two forms of prefixes in the system for each registrar the code itself and the old format from fred with CID pre-prefix so in this example both are ok TEST:123 and CID:TEST:123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Tests prepared TDD: autotests prepared
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants