Remove lib folder from autoload path
#859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 5, 2018 17:26
- Load extensions explicitly
maciej-szlosarczyk
approved these changes
Jun 6, 2018
| @@ -407,4 +400,26 @@ def session_timeout_reached? | |||
| timeout = 5.minutes | |||
| epp_session.updated_at < (Time.zone.now - timeout) | |||
| end | |||
|
|
|||
| def iptables_counter_update | |||
| return if ENV['iptables_counter_enabled'].blank? && ENV['iptables_counter_enabled'] != 'true' | |||
There was a problem hiding this comment.
The first part of this condition can be skipped, it's contained within the second one:
2.3.7 :004 > ''.blank?
=> true
2.3.7 :005 > '' != 'true'
=> true
2.3.7 :006 > nil != 'true'
=> true
2.3.7 :009 > 'false' != 'true'
=> true
2.3.7 :008 > 'true' != 'true'
=> false|
|
||
| def iptables_counter_update | ||
| return if ENV['iptables_counter_enabled'].blank? && ENV['iptables_counter_enabled'] != 'true' | ||
| return if current_user.blank? |
There was a problem hiding this comment.
That's also a bit weird, current_user shouldn't be a String, it should be an instance of User or Nil.
return unless current_user should communicate the intent better.
There was a problem hiding this comment.
I don't a see the point in improving code structure only. I think the whole feature should be refactored, which requires some effort and is definitely a topic of another branch/ticket.
artur-intech
force-pushed
the
remove-lib-from-autoload-path
branch
from
9ef2202 to
7a5a46b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: