Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin: removing certificate should revoke it first #887

Closed
vohmar opened this issue Jun 18, 2018 · 3 comments
Closed

Admin: removing certificate should revoke it first #887

vohmar opened this issue Jun 18, 2018 · 3 comments
Assignees
Labels

Comments

@vohmar
Copy link
Contributor

vohmar commented Jun 18, 2018

/admin/api_users/userid/certificates/certid

Removing unrevoked certificate prevents reusing same certificate signing request as there is effective certificate for that csr already in system. Deleting unrevoked certificate should first revoke the cert and only then delete it.

@maciej-szlosarczyk
Copy link
Contributor

We have missing tests around certificates, part of this fix would be to also introduce a testing suite for certificates controller (and model, of course).

@vohmar
Copy link
Contributor Author

vohmar commented Sep 20, 2018

removing PKI certs works fine. But removing EPP certs returns now error:

Using configuration from /home/registry/registry/shared/config/openssl.cnf#012ERROR:name does not match /C=EE/ST=Harjumaa/O=EIS/OU=staging reg2/CN=reg2-martin/emailAddress=...

PKI and EPP certs have different CAs

@maciej-szlosarczyk
Copy link
Contributor

@vohmar, please try again, @ratM1n and @teadur suggested a fix that might just work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants