Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty raise #192

Closed
stan-w opened this issue Apr 8, 2024 · 2 comments · Fixed by #200
Closed

Empty raise #192

stan-w opened this issue Apr 8, 2024 · 2 comments · Fixed by #200
Labels
question Further information is requested

Comments

@stan-w
Copy link

stan-w commented Apr 8, 2024

First of all, thanks for the repo! Safes a lot of time.

On https://github.com/Intility/fastapi-azure-auth/blob/1765e70275fc19786e78b1ad64886c50747ef1ea/fastapi_azure_auth/auth.py#L236 there is only a raise. Is this intended or should an InvalidAuth be raised?
@stan-w stan-w added the question Further information is requested label Apr 8, 2024
@JonasKs
Copy link
Member

JonasKs commented Apr 8, 2024

You’re right - PR welcome! 😊

@JonasKs JonasKs changed the title Empty raise [BUG/Question] Empty raise May 30, 2024
@JonasKs JonasKs mentioned this issue Jul 12, 2024
Merged
@JonasKs
Copy link
Member

JonasKs commented Jul 13, 2024

I've fixed this in #200.

@JonasKs JonasKs mentioned this issue Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v5 intility/fastapi-azure-auth
2 participants
@JonasKs @stan-w