Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack CLI flag can be the slack url #103

Merged
merged 1 commit into from
Dec 18, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

What Changed

--slack can be:

  • a string (this already worked)
  • a boolean - when boolean auto will look in the auto.config for a string (this didn't work, args.slack would have overridden config.slack)

Why

closes #23

Todo:

  • Add tests
  • Add docs
  • Add SemVer label

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Dec 18, 2018
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #103 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage      75%   74.92%   -0.08%     
==========================================
  Files          13       13              
  Lines         940      941       +1     
  Branches      137      138       +1     
==========================================
  Hits          705      705              
  Misses        208      208              
- Partials       27       28       +1
Impacted Files Coverage Δ
src/cli/args.ts 91.25% <ø> (ø) ⬆️
src/main.ts 23.55% <50%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6cabf3...f68e810. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #103 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage      75%   74.92%   -0.08%     
==========================================
  Files          13       13              
  Lines         940      941       +1     
  Branches      137      138       +1     
==========================================
  Hits          705      705              
  Misses        208      208              
- Partials       27       28       +1
Impacted Files Coverage Δ
src/cli/args.ts 91.25% <ø> (ø) ⬆️
src/main.ts 23.55% <50%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6cabf3...f68e810. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 253b423 into intuit:master Dec 18, 2018
@hipstersmoothie hipstersmoothie deleted the slack2 branch January 5, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Slack URL via CLI
1 participant