Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ignite #117

Merged
merged 1 commit into from
Jan 1, 2019
Merged

update ignite #117

merged 1 commit into from
Jan 1, 2019

Conversation

hipstersmoothie
Copy link
Collaborator

What Changed

update ignite

Why

it had security vulnerabilities in a dep

Todo:

  • Add tests
  • Add docs
  • Add SemVer label

@hipstersmoothie hipstersmoothie added skip-release Preserve the current version when merged internal Changes only affect the internal API labels Jan 1, 2019
@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files          14       14           
  Lines         963      963           
  Branches      137      137           
=======================================
  Hits          722      722           
  Misses        212      212           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549f077...201e9cf. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 1, 2019 •
edited
Loading

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #117   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files          14       14           
  Lines         963      963           
  Branches      137      137           
=======================================
  Hits          722      722           
  Misses        212      212           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549f077...201e9cf. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 3a6491d into intuit:master Jan 1, 2019
@hipstersmoothie hipstersmoothie deleted the deps2 branch January 1, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal Changes only affect the internal API skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hipstersmoothie