Include a log when creating a new labels about what those labels are #121
Conversation
|
Alternative take: also print out a url like: |
|
Awesome! I like the idea of printing the URL also. I'll merge once you add that 👍
|
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
=======================================
Coverage 75.02% 75.02%
=======================================
Files 14 14
Lines 973 973
Branches 137 137
=======================================
Hits 730 730
Misses 214 214
Partials 29 29
Continue to review full report at Codecov.
|
orta
force-pushed
the
include_log_for_creating_labels
branch
from
def3e0e to
6dcb3d3
Compare
src/git.ts
Outdated
|
|
||
| return Promise.resolve(); | ||
| } | ||
|
|
||
| // Looks like: https://developer.github.com/v3/repos/#get | ||
| public async getRepoMetadata(): Promise<any> { |
There was a problem hiding this comment.
it looks like this.ghub.repos.get return a type of GHub.Response<GHub.ReposGetResponse> so the return type for this function should probably be Promise<GHub.Response<GHub.ReposGetResponse>>
There was a problem hiding this comment.
| public async getRepoMetadata(): Promise<any> { | |
| public async getRepoMetadata(): Promise<GHub.Response<GHub.ReposGetResponse>> { |
There was a problem hiding this comment.
Good point, if I remove the return type annotation it'll be inferred correctly - I've removed that 👍
orta
force-pushed
the
include_log_for_creating_labels
branch
from
6dcb3d3 to
f171ebf
Compare
What Changed
->Why
I didn't know what the labels would be, and even after creating them I didn't.
I couldn't find any other uses of the
logger.logwhich makes me think this is the wrong way to do it?Todo: