Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only set git user if one isn't already set #125

Merged
merged 2 commits into from
Jan 3, 2019

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jan 3, 2019

What Changed

Previously auto would override the local git user with whatever was in the package.json author field.

Now:

  • it first checks that one isn't set before configuring the email and name
  • only tries to set the git user during changelog or shipit
  • If a user is running npm version themselves (rather than using shipit) they are required to set the git config manually

Why

closes #124

Todo:

  • Add tests (This file is still fully untested)
  • Add docs
  • Add SemVer label

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jan 3, 2019
@codecov
Copy link

codecov bot commented Jan 3, 2019

Codecov Report

Merging #125 into master will decrease coverage by 0.84%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   75.02%   74.18%   -0.85%     
==========================================
  Files          14       14              
  Lines         973      976       +3     
  Branches      137      137              
==========================================
- Hits          730      724       -6     
- Misses        214      225      +11     
+ Partials       29       27       -2
Impacted Files Coverage Δ
src/main.ts 20.28% <14.28%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc47af5...19b80a7. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit ba786d0 into intuit:master Jan 3, 2019
@hipstersmoothie hipstersmoothie deleted the git-user branch January 3, 2019 18:02
@orta
Copy link
Contributor

orta commented Jan 3, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git Config is manipulated outside of auto shipit
2 participants