Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move login out of CLI #33

Merged
merged 5 commits into from
Dec 7, 2018
Merged

Move login out of CLI #33

merged 5 commits into from
Dec 7, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

What Changed

closes #31

Why

Enabling more reusage of code

Todo:

  • Add tests
  • Add docs
  • Add SemVer label

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #33 into master will increase coverage by 0.51%.
The diff coverage is 56.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   80.46%   80.97%   +0.51%     
==========================================
  Files          11       12       +1     
  Lines         778      778              
  Branches      104      103       -1     
==========================================
+ Hits          626      630       +4     
+ Misses        137      131       -6     
- Partials       15       17       +2
Impacted Files Coverage Δ
src/log-parse.ts 93.61% <ø> (ø) ⬆️
src/git.ts 99.25% <ø> (ø) ⬆️
src/bin/auto.ts 0% <0%> (-19.52%) ⬇️
src/main.ts 22.78% <21.79%> (-71.89%) ⬇️
src/github-release.ts 94.66% <94.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22b4357...af2583d. Read the comment docs.

@adierkens adierkens merged commit 20d42c0 into master Dec 7, 2018
@adierkens adierkens deleted the meta branch December 7, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factor CLI logic out of main
2 participants