Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only error if there are actually missing args #95

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

What Changed

fixed a bug

Why

even with all required args the CLI would exit

Todo:

  • Add tests
  • Add docs
  • Add SemVer label

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Dec 17, 2018
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #95 into master will decrease coverage by 0.07%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   75.05%   74.97%   -0.08%     
==========================================
  Files          13       13              
  Lines         946      947       +1     
  Branches      132      138       +6     
==========================================
  Hits          710      710              
  Misses        209      209              
- Partials       27       28       +1
Impacted Files Coverage Δ
src/cli/args.ts 91.66% <60%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d5d7d...832dc27. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #95 into master will decrease coverage by 0.07%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   75.05%   74.97%   -0.08%     
==========================================
  Files          13       13              
  Lines         946      947       +1     
  Branches      132      138       +6     
==========================================
  Hits          710      710              
  Misses        209      209              
- Partials       27       28       +1
Impacted Files Coverage Δ
src/cli/args.ts 91.66% <60%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d5d7d...832dc27. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 4469bcf into intuit:master Dec 17, 2018
@hipstersmoothie hipstersmoothie deleted the bug branch December 17, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant