Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-check wasn't getting semver labelTexts correctly #98

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

hipstersmoothie
Copy link
Collaborator

What Changed

switch to Map methods

Why

closes #97

Todo:

  • Add tests
  • Add docs
  • Add SemVer label

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Dec 17, 2018
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files          13       13           
  Lines         947      947           
  Branches      138      133    -5     
=======================================
  Hits          710      710           
  Misses        209      209           
  Partials       28       28
Impacted Files Coverage Δ
src/main.ts 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd8501...9e196a5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files          13       13           
  Lines         947      947           
  Branches      138      133    -5     
=======================================
  Hits          710      710           
  Misses        209      209           
  Partials       28       28
Impacted Files Coverage Δ
src/main.ts 23.8% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd8501...9e196a5. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit dbda3a4 into intuit:master Dec 17, 2018
@hipstersmoothie hipstersmoothie deleted the fix-pr-check branch December 17, 2018 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci/pr-check seems broken
1 participant