Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about latest version retrieval using github actions (no npm) and git-tags #1588

Open
smoia opened this issue Oct 14, 2020 · 7 comments

Comments

@smoia
Copy link

smoia commented Oct 14, 2020

I tried to setup auto in a python repository, without using npm - downloading the latest release from github - with this Github action.
From the last log of the action, the one before, and the first one after merging auto , it seems like auto retrieves the latest release correctly, but then:

  • it seems like the labels are not set in the repository, when they are (I ran auto create-labels a couple of times to be sure)
  • it seems like it uses the version before the last one to compute the new version
  • it fails because the version it computed already exists.

Am I missing something in the configuration files?

@hipstersmoothie
Copy link
Collaborator

@smoia are you still experiencing these issues?

@smoia
Copy link
Author

smoia commented Oct 27, 2020

Hello @hipstersmoothie! Yes and no: Yes because when I call auto release I do have this issue, no because if I use auto shipit I don't. In fact, the set up is now working quite well (we release a couple of versions with it) - let's see if it will be ok with the move to v10!
If you want, you can add our action to the documentation as an example of GitHub action that is not using npm.

@hipstersmoothie
Copy link
Collaborator

@smoia I'd happily accept a PR for those changes. Let's get you on that contributor list 😉

@hipstersmoothie
Copy link
Collaborator

I think the problem stems from a misunderstanding:

  • auto release - Creates a GitHub release for the last tag in the repo
  • auto shipit - Will create the tag and call auto release

@smoia
Copy link
Author

smoia commented Oct 28, 2020

I see, and now that's clear, thank you! May I suggest a tiny change to the documentation in this case? Just to make 100% more clear the difference between shipit and release.

@hipstersmoothie
Copy link
Collaborator

Go for it!

@alinaMihai
Copy link

alinaMihai commented Dec 16, 2021

What would be a reason for the auto shipit not to add the latest label on the tag it created?
I have previously made a manual release from Github interface with a release tag. I am using an individually versioned configuration for lerna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants