Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RNSI ALGERIE 2020 #1006

Merged
merged 12 commits into from
Nov 4, 2024
Merged

Add RNSI ALGERIE 2020 #1006

merged 12 commits into from
Nov 4, 2024

Conversation

AbdouSou
Copy link
Contributor

@AbdouSou AbdouSou commented Nov 2, 2024

Ajout du réferentiel National de l'Algerie 2020.

Ajout du réferentiel National de l'algerie 2020.
Copy link

github-actions bot commented Nov 2, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@AbdouSou
Copy link
Contributor Author

AbdouSou commented Nov 2, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 2, 2024
@eric-intuitem
Copy link
Collaborator

Merci pour cette contribution ! Voilà quelques remarques pour l'améliorer :

  • Pour les URNs internes (framework, nodes...), il serait préférable pour être consistent d'utiliser urn:intuitem:risk:framework:RNSI-ALGERIE-2020.
  • Est-il possible de fournir également le fichier Excel ? Cela permet une relecture plus simple du contenu.
  • Pour locale il s'agit de la langue (pas du pays), donc il faut mettre fr.

change locale : fr 
URNs internes (framework, nodes...), utiliser urn:intuitem:risk:framework:RNSI-ALGERIE-2020.
@AbdouSou
Copy link
Contributor Author

AbdouSou commented Nov 3, 2024

Merci pour cette contribution ! Voilà quelques remarques pour l'améliorer :

  • Pour les URNs internes (framework, nodes...), il serait préférable pour être consistent d'utiliser urn:intuitem:risk:framework:RNSI-ALGERIE-2020.
  • Est-il possible de fournir également le fichier Excel ? Cela permet une relecture plus simple du contenu.
  • Pour locale il s'agit de la langue (pas du pays), donc il faut mettre fr.

Done please Check

Rename File : RNSI-ALGERIE-2020
Locale : FR -> fr
packager : EKSEC.net
- Delete Implementation groups . 
- Fix score 5 : N/A ( Not Applicable)
delete score 5 : N/A
Change Scores from 5 to 4
Change Desc to MPT Algérie.
Change Description and FR->fr
Provider : MPT ALGERIE
@ab-smith ab-smith self-requested a review November 4, 2024 12:54
@ab-smith ab-smith merged commit 6471fc9 into intuitem:main Nov 4, 2024
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants