Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate convert(AnchoredInterval{Ending}, ...) and convert(AnchoredInterval{Beginning}, ...) #109

Open
omus opened this issue Jun 23, 2020 · 0 comments

Comments

@omus
Copy link
Collaborator

omus commented Jun 23, 2020

As discussed in another PR the covert methods using AnchoredInterval{Ending} and Anchored{Beginning} should be dropped as:

  1. Ending / Beginning is not a period
  2. You can't have an instance of AnchoredInterval{Ending} or AnchoredInterval{Beginning}
  3. The invariant convert(T, x)::T should always hold in every convert method

With that said, these convert methods have been very useful for generic testing in test/comparisons.jl so we should find an alternate way of providing this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant