Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about reflect-metadata is now misleading #1139

Open
terrybondy opened this issue Aug 26, 2019 · 1 comment
Open

Documentation about reflect-metadata is now misleading #1139

terrybondy opened this issue Aug 26, 2019 · 1 comment

Comments

@terrybondy
Copy link

The documentation at https://github.com/inversify/InversifyJS/blob/master/wiki/environment.md contains the following note:

⚠️ The reflect-metadata polyfill should be imported only once in your entire application because the Reflect object is mean to be a global singleton. More details about this can be found here.

Related issues in the dependency:
#80 - metadata seemingly erased when using multiple files with karma,mocha,webpack
#78 - Error when working with another polyfill, like core-js/reflect
#45 - When installed redundantly, Metadata could be erased

seem to have been fixed (https://github.com/rbuckton/reflect-metadata/releases/tag/v0.1.12) in a previously used version of the dependency.

Expected Behavior

No note required.

Current Behavior

Has note.

Possible Solution

Remove note.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop or mobile):
  • Link to your project:

Stack trace

@zanminkian
Copy link

Can't agree more. The newest version of reflect-metadata, which has been released for more than 4 year, can be imported more than once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants